Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: refactor regitster function #889

Merged
merged 1 commit into from
Aug 14, 2024

Conversation

deepin-mozart
Copy link
Contributor

Delayed creation improves efficiency

Log:
Change-Id: Ia87a3799846ee2f08ecee17d9b6cd4aa867aac86

Delayed creation improves efficiency

Log:
Change-Id: Ia87a3799846ee2f08ecee17d9b6cd4aa867aac86
@deepin-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: deepin-mozart

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@deepin-ci-robot
Copy link

deepin pr auto review

关键摘要:

  • Collaborators::start()函数中,移除了windowService->registerWidget()调用,改为使用windowService->registerWidgetCreator()。需要确认这是否符合预期功能变更。
  • PluginManagerModule::initialize()中,移除了uiController->registerWidget()uiController->registerWidget()的调用,改为使用uiController->registerWidgetCreator()。需要验证这些更改是否不会影响插件管理器的功能。
  • Controller::createDockWidget()中,移除了d->mainWindow->addWidget()的调用,改为使用info.getDWidget()来获取 dock widget。需要验证这是否符合预期功能变更。
  • Controller::registerWidget()Controller::registerWidgetToMode()中,移除了widgetInfo.widget的赋值,改为使用widgetInfo.getDWidget()来获取 dock widget。需要验证这是否符合预期功能变更。

是否建议立即修改:

  • 是,需要确保这些更改不会引入新的错误或不兼容性。特别是功能变更部分,需要确保它们不会破坏现有的插件加载和窗口管理功能。

@deepin-ci-robot deepin-ci-robot merged commit 529b658 into linuxdeepin:master Aug 14, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants